1 回答
![?](http://img1.sycdn.imooc.com/5333a01a0001ee5302000200-100-100.jpg)
TA贡献1829条经验 获得超4个赞
您遇到的问题是由于您使用querySelectorAll
which 不仅选择第一层子节点,而且会直接钻入 DOM 并检索所有匹配的节点。一个简单的解决方案可能是通过添加属性来区分子选项卡和父选项卡,并为子项使用单独的处理程序。更全面的方法可能只涉及对顶级选项卡和选项卡内容进行操作。
(为了其他用户的可读性,我在代码中添加了英文注释并删除了外国注释)
'use strict';
document.addEventListener('DOMContentLoaded', function () {
var tabs = document.getElementsByClassName('tabs');
if (tabs) {
var _loop = function _loop() {
var tabListItems = tabs[i].querySelectorAll('li');
tabListItems.forEach(function (tabListItem) {
tabListItem.addEventListener('click', function (e) {
// Select any siblings of the current tab.
let siblings = Array.from(tabListItem.parentElement.children);
// Remove the is-active status from all siblings
siblings.forEach(function (element) {
element.classList.remove('is-active');
});
// Add the is-active status to the selected tab.
tabListItem.classList.add('is-active');
var tabName = tabListItem.dataset.tab;
// Same as above, rather than selecting all of the js-tab-content
// elements, we only select those which are at the same level as
// the selected tab.
let tabsContainer = tabListItem.closest('.js-tabs-container');
let tabsContainerChildren = Array.from(tabsContainer.children);
// Filter out other children that aren't js-tab-content elements.
let tabs = tabsContainerChildren.filter(function(el) {
return el.className.includes('js-tab-content')
});
tabs.forEach(function(tabContent) {
if (tabContent.id !== tabName) {
tabContent.classList.add('has-display-none');
} else {
tabContent.classList.remove('has-display-none');
}
})
}, false);
});
};
for (var i = 0; i < tabs.length; i++) {
_loop();
}
}
});
假设您的结构大体保持不变,这对于任何级别的嵌套选项卡都应该正确运行,因为选择选项卡时唯一受影响的项目是它周围的屏幕和链接。
重构
使用箭头函数,并在不需要的地方分配较少的变量将使您能够编写更短更简洁的代码。这是一个示例,不一定是编写它的最佳方式,但它可能会给您一些提取函数和链接数组迭代的想法。
document.addEventListener('DOMContentLoaded', () => {
Array.from(document.getElementsByClassName('tabs')).forEach(tab => {
tab.querySelectorAll('li').forEach(listItem => {
listItem.addEventListener('click', tabClickHandler(listItem), false);
});
});
});
function tabClickHandler (listItem) {
return () => {
let siblings = Array.from(listItem.parentElement.children);
siblings.forEach(el => el.classList.remove('is-active'));
listItem.classList.add('is-active');
let tabName = listItem.dataset.tab;
Array.from(listItem.closest('.js-tabs-container').children)
.filter(el => el.classList.contains('js-tab-content'))
.forEach(tab => {
if (tab.id !== tabName) {
tab.classList.add('has-display-none');
} else {
tab.classList.remove('has-display-none');
}
});
}
}
添加回答
举报