多表分页存储过程， 这样写会不会出问题

Question

USE [MFProNew]GO/****** 对象: StoredProcedure [dbo].[GetRecordByPage] 脚本日期: 02/12/2011 10:13:23 ******/SET ANSI_NULLS ONGOSET QUOTED_IDENTIFIER ONGOALTER PROCEDURE [dbo].[GetRecordByPage](@tblName nvarchar(400), ----要显示的表或多个表的连接@fldName nvarchar(4000) = '*', ----要显示的字段列表@pageSize int = 1, ----每页显示的记录个数@page int = 10, ----要显示那一页的记录@pageCount int = 1 output, ----查询结果分页后的总页数@Counts int = 1 output, ----查询到的记录数@fldSort nvarchar(200) = null, ----排序字段列表或条件@Sort bit = 1, ----排序方法，0为升序，1为降序(如果是多字段排列Sort指代最后一个排序字段的排列顺序(最后一个排序字段不加排序标记)--程序传参如：' SortA Asc,SortB Desc,SortC ')@strCondition nvarchar(4000) = null, ----查询条件,不需where@ID nvarchar(150), ----主表的主键@Dist bit = 0 ----是否添加查询字段的 DISTINCT 默认0不添加/1添加)ASSET NOCOUNT ONDeclare @sqlTmp nvarchar(4000) ----存放动态生成的SQL语句Declare @strTmp nvarchar(4000) ----存放取得查询结果总数的查询语句Declare @strID nvarchar(4000) ----存放取得查询开头或结尾ID的查询语句Declare @strSortType nvarchar(10) ----数据排序规则ADeclare @strFSortType nvarchar(10) ----数据排序规则BDeclare @SqlSelect nvarchar(50) ----对含有DISTINCT的查询进行SQL构造Declare @SqlCounts nvarchar(50) ----对含有DISTINCT的总数查询进行SQL构造if @Dist = 0begin set @SqlSelect = 'select ' set @SqlCounts = 'Count(*)'endelsebegin set @SqlSelect = 'select distinct ' set @SqlCounts = 'Count(DISTINCT '+@ID+')'endif @Sort=0begin set @strFSortType=' ASC ' set @strSortType=' DESC 'endelsebegin set @strFSortType=' DESC ' set @strSortType=' ASC 'end--------生成查询语句----------此处@strTmp为取得查询结果数量的语句if @strCondition is null or @strCondition='' --没有设置显示条件begin set @sqlTmp = @fldName + ' From ' + @tblName set @strTmp = @SqlSelect+' @Counts='+@SqlCounts+' FROM '+@tblName set @strID = ' From ' + @tblNameendelsebegin set @sqlTmp = + @fldName + 'From ' + @tblName + ' where (1>0) ' + @strCondition set @strTmp = @SqlSelect+' @Counts='+@SqlCounts+' FROM '+@tblName + ' where (1>0) ' + @strCondition set @strID = ' From ' + @tblName + ' where (1>0) ' + @strConditionend----取得查询结果总数量-----exec sp_executesql @strTmp,N'@Counts int out ',@Counts outprint @strTmpdeclare @tmpCounts intif @Counts = 0 set @tmpCounts = 1else set @tmpCounts = @Counts --取得分页总数 set @pageCount=(@tmpCounts+@pageSize-1)/@pageSize /**//**当前页大于总页数 取最后一页**/ if @page>@pageCount set @page=@pageCount --/*-----数据分页2分处理-------*/ declare @pageIndex int --总数/页大小 declare @lastcount int --总数%页大小 set @pageIndex = @tmpCounts/@pageSize set @lastcount = @tmpCounts%@pageSize if @lastcount > 0 set @pageIndex = @pageIndex + 1 else set @lastcount = @pagesize --//***显示分页 if @strCondition is null or @strCondition='' --没有设置显示条件 begin if @pageIndex<2 or @page<=@pageIndex / 2 + @pageIndex % 2 --前半部分数据处理 begin set @strTmp=@SqlSelect+' top '+ CAST(@pageSize as VARCHAR(4))+' '+ @fldName+' from '+@tblName +' where '+@ID+' not in('+ @SqlSelect+' top '+ CAST(@pageSize*(@page-1) as Varchar(20)) +' '+ @ID +' from '+@tblName +' order by '+ @fldSort +' '+ @strFSortType+')' +' order by '+ @fldSort +' '+ @strFSortType end else begin set @page = @pageIndex-@page+1 --后半部分数据处理 if @page <= 1 --最后一页数据显示 set @strTmp=@SqlSelect+' top '+ CAST(@lastcount as VARCHAR(4))+' '+ @fldName+' from '+@tblName +' order by '+ @fldSort +' '+ @strSortType else set @strTmp=@SqlSelect+' top '+ CAST(@pageSize as VARCHAR(4))+' '+ @fldName+' from '+@tblName +' where '+@ID+' not in('+ @SqlSelect+' top '+ CAST(@lastcount as Varchar(20)) +' '+ @ID +' from '+@tblName +' order by '+ @fldSort +' '+ @strSortType+')' +' order by '+ @fldSort +' '+ @strSortType end end else --有查询条件 begin if @pageIndex<2 or @page<=@pageIndex / 2 + @pageIndex % 2 --前半部分数据处理 begin set @strTmp=@SqlSelect+' top '+ CAST(@pageSize as VARCHAR(4))+' '+ @fldName +' from '+@tblName +' where '+@ID+' not in('+ @SqlSelect+' top '+ CAST(@pageSize*(@page-1) as Varchar(20)) +' '+ @ID +' from '+@tblName +' Where (1>0) ' + @strCondition + ' order by '+ @fldSort +' '+ @strFSortType+')' +' ' + @strCondition + ' order by '+ @fldSort +' '+ @strFSortType end else begin set @page = @pageIndex-@page+1 --后半部分数据处理 if @page <= 1 --最后一页数据显示 set @strTmp=@SqlSelect+' top '+ CAST(@lastcount as VARCHAR(4))+' '+ @fldName+' from '+@tblName +' where (1>0) '+ @strCondition +' order by '+ @fldSort +' '+ @strSortType else set @strTmp=@SqlSelect+' top '+ CAST(@pageSize as VARCHAR(4))+' '+ @fldName+' from '+@tblName +' where '+@ID+' not in('+ @SqlSelect+' top '+ CAST(@lastcount as Varchar(20)) +' '+ @ID +' from '+@tblName +' where (1>0) '+ @strCondition +' order by '+ @fldSort +' '+ @strSortType+')' + @strCondition +' order by '+ @fldSort +' '+ @strSortType end end------返回查询结果-----print @strTmpexec sp_executesql @strTmp--print @strTmpSET NOCOUNT OFF  

Answer 1

个人感觉没有必要过分追求通用吧，这种方式即使成功实现了，执行效率也是问题吧。

还是根据具体的业务逻辑，分别实现分页存储过程，这样逻辑更清晰、结构更合理，针对特定的语句也可以进行优化，执行效率更好。